Notify and surface when a remote/cloud-agent session needs input by iscekic · Pull Request #4605 · Kilo-Org/cloud

iscekic · 2026-07-16T23:21:09Z

Summary

Notifies and surfaces when a Kilo session (remote CLI or cloud agent) needs user input — a push notification plus an in-app indicator in the mobile Agents session list.

Backend push triggers

session-ingest: flips REMOTE_SESSION_ATTENTION_PUSH_ENABLED to true, enabling the existing remote-session attention push path for active CLI sessions.
cloud-agent-next: adds a raise-only attention classifier (question.asked / permission.asked) and dispatches a push notification when such an event occurs on a cloud-agent-web session, gated by presence (suppressed if a client is actively viewing the session) and session/child-session identity checks.

Both slices are additive and raise-only: there is no resolve/clear push, no outbox, scheduler, alarm, or migration. Push payload status remains 'completed' for needs-input notifications, matching existing deployed-schema expectations (#4445).

Session title in push notifications

Session pushes now lead with the session's own title so a notification reads as "" over the descriptive body, instead of a generic title for every session.

A shared sanitizeTitle helper (in services/notifications) trims, collapses internal whitespace, truncates to at most 80 code points (Unicode-safe, appending ...), and returns null for empty/whitespace-only titles.
Session-ready push title resolves as sanitizeTitle(heartbeatTitle) ?? sanitizeTitle(dbTitle) ?? 'Kilo session ready'. The live heartbeat title is threaded through UserConnectionDO → SessionIngestDO → sendSessionReadyNotification, with an optional title added to the ready-notification RPC schema in @kilocode/notifications.
Cloud-agent session push title resolves as sanitizeTitle(session.title) ?? 'Agent session'; the needs-input body is unchanged (Kilo needs your input.).

Additive and defensive: when a title is missing or empty the existing generic fallback is used, so no notification regresses.

In-app session-list indicator (mobile)

When a session's status is question or permission, its row in the mobile Agents session list shows a soft-pulsing amber (warn-tone) StatusDot plus a NEEDS INPUT meta label (and "needs input" in the row's accessibilityLabel), replacing the green live dot / timestamp meta. The indicator clears when the status leaves needs-input or when the user opens the session.

Reads the status/status_updated_at already carried by cliSessionsV2.list/search/get and activeSessions.list — no backend, tRPC, or DB changes for this surface. Web's SessionStatusIndicator is the production precedent.
session-attention.ts: a small predicate plus an in-memory, per-raise ack store (single writer = the session detail screen mount). Acks are intentionally not persisted across app restarts, so a genuinely unanswered question honestly re-raises. The store is anchored on globalThis so the detail-screen writer and the session-list readers share one instance across Expo Router route bundles.
StatusDot gains an opt-in pulse prop (soft opacity breathe, static under useReducedMotion); default off leaves all existing call sites unchanged.
The Agents list remounts on attention-revision change after refocus so the freezeOnBlur tab reliably reflects the clear-on-open ack on return.

Not included on this surface: Home-screen wiring, ack persistence, and any indicator inside the session detail screen.

Testing

services/session-ingest: full suite green, typecheck, lint clean (includes heartbeat-title threading tests).
services/notifications: full suite green, typecheck, lint clean (includes sanitizeTitle unit tests covering trim/whitespace-collapse, 80-code-point truncation with ..., Unicode surrogate-pair truncation, lone-surrogate safety, empty-title fallback, and title-lead composition for both session-ready and cloud-agent pushes).
@kilocode/notifications: typecheck, lint clean (optional title on the ready-notification RPC schema).
services/cloud-agent-next: full suite green, typecheck, lint clean.
apps/mobile: format, typecheck, lint, check:unused, and unit tests all green, including the session-attention predicate/ack-store state machine.
Fresh independent code reviews on the push work, the in-app indicator, and the session-title addition: no actionable findings.
E2E on iOS simulator:
- Push work: verified push wiring, presence-suppression gates, idempotent single-push-per-signal behavior, and simulated APNs delivery (xcrun simctl push) for both payload shapes.
- Session title: verified end to end via a live CLI/heartbeat fixture that the composed push payload leads with the session title — a titled session-ready push, an 80-code-point-truncated title ending in ..., the Kilo session ready fallback for an empty title, and a titled needs-input push (Kilo needs your input. body) — confirmed against the notifications service delivery logs. Pixel-level rendering of the iOS notification banner could not be screenshotted in the local simulator because a freshly-installed dev-client cannot be granted notification authorization non-interactively (simctl privacy has no notifications service); this is a generic simulator environment limitation, not a gap in this change, and OS-level delivery was confirmed (willPresentNotification).
- In-app indicator: verified a stored question/permission row shows the amber pulsing dot + NEEDS INPUT label and "needs input" accessibility label; a non-attention control row shows neither; the indicator clears on status change and on opening the session (and re-shows on a new raise); the remote/active-only row shows and clears via a live user-connection heartbeat fixture; and the dot renders statically under Reduce Motion with no hard blink.
- Real APNs-to-physical-device delivery and live LLM-triggered question events are not verifiable in the local dev environment (missing EXPO_ACCESS_TOKEN, no deterministic interactive-prompt harness) and are documented as accepted limitations, consistent with prior related work (feat(mobile): notify when agent sessions need input #4545).

…attention-notifications

Anchor the attention ack store on globalThis so the single-writer detail screen and the session-list readers share one instance across Expo Router route bundles, and remount the Agents list on attention-revision change after refocus so the freezeOnBlur'd list re-reads the ack store on return.

kilo-code-bot · 2026-07-18T00:21:11Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Since the last review, the PR added session-title threading into push notifications (a sanitizeTitle helper, an optional title on the ready-notification RPC schema, and title plumbing from UserConnectionDO → SessionIngestDO → the notification dispatchers); the change is additive, backward-compatible, and covered by thorough new unit tests, with no issues found in changed code.

Files Reviewed (7 files changed)

packages/notifications/src/rpc-schemas.ts - 0 issues (additive optional field)
services/notifications/src/lib/cloud-agent-session-push.ts - 0 issues (new sanitizeTitle helper and title-resolution fallback chain)
services/notifications/src/lib/notifications-service-cloud-agent.test.ts - 0 issues (new tests only)
services/session-ingest/src/dos/SessionIngestDO.ts - 0 issues (optional title threaded through to the push RPC)
services/session-ingest/src/dos/SessionIngestDO.test.ts - 0 issues (new tests only)
services/session-ingest/src/dos/UserConnectionDO.ts - 0 issues (heartbeat session title passed to the claim call)
services/session-ingest/src/dos/UserConnectionDO.test.ts - 0 issues (test-only update)

Previous Review Summaries (3 snapshots, latest commit feeed49)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit `feeed49`)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

Only a trivial formatting change (wrapping an arrow-function body in braces in a test file) was made since the last review; no logic changed and the previously-fixed issues remain fixed.

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
`apps/mobile/src/lib/session-attention.ts`	26	Ack-store `entries` Map has no eviction path for sessions that are abandoned before their status leaves the attention state (author has declined to change, by design)

Files Reviewed (1 file changed)

apps/mobile/src/lib/session-attention.test.ts - 0 issues (style-only change, no logic difference)

Fix these issues in Kilo Cloud

Previous review (commit `dc86ab9`)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

Three of the four previously flagged issues (metadata-fetch outside try, throwing listener aborting notification, and over-broad list remount) are fixed in the latest commits; one lower-severity suggestion remains unaddressed.

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
`apps/mobile/src/lib/session-attention.ts`	26	Ack-store `entries` Map has no eviction path for sessions that are abandoned before their status leaves the attention state

Files Reviewed (4 files)

apps/mobile/src/components/agents/session-list-content.tsx - 0 issues (fixed: list now remounts only on focus-regain, not on every unrelated attention change)
apps/mobile/src/lib/session-attention.test.ts - 0 issues
apps/mobile/src/lib/session-attention.ts - 1 issue (fixed: throwing listener now isolated with try/catch)
services/cloud-agent-next/src/persistence/CloudAgentSession.ts - 0 issues (fixed: getMetadata() now called inside the try block)

Fix these issues in Kilo Cloud

Previous review (commit `1602719`)

Status: 4 Issues Found | Recommendation: Address before merge

Executive Summary

The highest-risk issue is in CloudAgentSession.ts, where the new attention-push handler fetches session metadata outside its try block, so a metadata-parse failure would break the documented "log and swallow" guarantee for this best-effort push path.

Overview

Severity	Count
CRITICAL	0
WARNING	2
SUGGESTION	2

Issue Details (click to expand)

WARNING

File	Line	Issue
`services/cloud-agent-next/src/persistence/CloudAgentSession.ts`	683	`getMetadata()` called outside the `try` block, breaking the documented swallow-and-log guarantee on failure
`apps/mobile/src/components/agents/session-list-content.tsx`	213	Global attention-revision counter used as the `SectionList` key causes a full remount/scroll reset on any unrelated session's attention change

SUGGESTION

File	Line	Issue
`apps/mobile/src/lib/session-attention.ts`	26	Ack-store `entries` Map has no eviction path for sessions that are abandoned before their status leaves the attention state
`apps/mobile/src/lib/session-attention.ts`	41	A throwing listener in `bumpRevision`'s notify loop aborts notification to remaining subscribers

Files Reviewed (14 files)

apps/mobile/src/app/(app)/agent-chat/[session-id].tsx - 0 issues
apps/mobile/src/components/agents/session-list-content.tsx - 1 issue
apps/mobile/src/components/agents/session-row.tsx - 0 issues
apps/mobile/src/components/ui/session-row.tsx - 0 issues
apps/mobile/src/components/ui/status-dot.tsx - 0 issues
apps/mobile/src/lib/session-attention.test.ts - 0 issues
apps/mobile/src/lib/session-attention.ts - 2 issues
services/cloud-agent-next/src/persistence/CloudAgentSession.ts - 1 issue
services/cloud-agent-next/src/websocket/ingest-attention-classifier.test.ts - 0 issues
services/cloud-agent-next/src/websocket/ingest-attention-classifier.ts - 0 issues
services/cloud-agent-next/src/websocket/ingest.test.ts - 0 issues
services/cloud-agent-next/src/websocket/ingest.ts - 0 issues
services/session-ingest/src/remote-session-notifications.test.ts - 0 issues
services/session-ingest/src/remote-session-notifications.ts - 0 issues

Fix these issues in Kilo Cloud

_{Reviewed by claude-sonnet-5 · Input: 60 · Output: 11.6K · Cached: 2.4M}

_{Review guidance: REVIEW.md from base branch main}

- cloud-agent-next: fetch session metadata inside the attention-push try/catch so a metadata failure is logged and swallowed as documented, never breaking the best-effort ingest path. - mobile: key the Agents list on an attention revision snapshotted at tab focus, so it remounts to re-read the ack store only on return from a just-opened session, not on any unrelated session's attention change during browsing (preserving scroll). - mobile: isolate attention-store subscribers so one throwing listener cannot prevent the rest from being notified.

iscekic · 2026-07-18T00:37:03Z

(bot) Thanks — addressed in dc86ab994:

WARNING — CloudAgentSession.ts getMetadata() outside try: Fixed. Moved the await this.getMetadata() call inside the existing try block so a metadata failure is logged and swallowed, preserving the documented best-effort contract for this ctx.waitUntil push path.
WARNING — session-list-content.tsx global revision as SectionList key: Fixed. The list is now keyed on the attention revision snapshotted only at tab focus (useFocusEffect → getRevisionSnapshot()), so it remounts to re-read the ack store exactly when an ack/reconcile happened while the list was away (returning from a just-opened session). A revision bump for an unrelated session during active browsing no longer changes the snapshot, so scroll is preserved. The freeze-driven remount is required because freezeOnBlur + react-freeze reveal stale cached cells on return without re-running them.
SUGGESTION — throwing listener aborts bumpRevision notify loop: Fixed. Each subscriber call is wrapped in try/catch so one throwing listener cannot prevent the rest from being notified; added a unit test asserting a later subscriber still runs once and the revision increments exactly once.
SUGGESTION — ack-store entries eviction: Not changed, by design. Entries are created only for sessions the user opens and are deleted on the next observed non-attention status (reconcileSessionAttention); each entry is a tiny { raiseId } keyed by session id, the store is per-app-run in-memory (never persisted), and it is cleared on restart. The only residue is an opened, still-attention session that leaves the list before a non-attention status is observed — bounded by distinct sessions opened per run and negligible in size. Adding an eviction policy would add complexity without a meaningful benefit.

oxlint no-confusing-void-expression forbids returning the void expression from the arrow shorthand passed to expect().

Thread the heartbeat session title from UserConnectionDO through SessionIngestDO into the notifications service so attention and session-ready push notifications lead with the session title. - packages/notifications: optional title on sendSessionReadyNotificationInputSchema. - services/notifications: add a code-point-safe title sanitizer (collapse whitespace, <=80 code points incl. ellipsis, no split surrogate) used by dispatchCloudAgentSessionPush and the ready push. Ready push prefers the heartbeat title hint, then the DB title, then the fixed 'Kilo session ready'. - services/session-ingest: forward the heartbeat title from UserConnectionDO.claimSessionReadyPush into SessionIngestDO and on to sendSessionReadyNotification. - Tests cover title composition, long-title and surrogate-pair truncation, whitespace handling, hint-vs-DB precedence, and schema strip-on-parse.

iscekic added 2 commits July 17, 2026 00:43

feat(session-ingest): enable remote session attention pushes

3ca8935

feat(cloud-agent): push notification when a session needs input

32d0a34

iscekic self-assigned this Jul 16, 2026

iscekic requested review from eshurakov and jeanduplessis July 17, 2026 01:19

iscekic added 5 commits July 17, 2026 22:19

Merge remote-tracking branch 'origin/main' into feature/mobile-agent-…

df645b0

…attention-notifications

feat(mobile): session attention derivation and ack store

8f0fbf5

feat(mobile): soft pulse option for StatusDot

b43be81

feat(mobile): needs-input indicator in session list

635eadd

iscekic changed the title ~~Push notification when a remote/cloud-agent session needs input~~ Notify and surface when a remote/cloud-agent session needs input Jul 18, 2026

kilo-code-bot Bot reviewed Jul 18, 2026

View reviewed changes

Comment thread services/cloud-agent-next/src/persistence/CloudAgentSession.ts Outdated

Comment thread apps/mobile/src/lib/session-attention.ts

Comment thread apps/mobile/src/lib/session-attention.ts Outdated

Comment thread apps/mobile/src/components/agents/session-list-content.tsx Outdated

iscekic added 2 commits July 18, 2026 02:40

test(mobile): use block body in listener-isolation test

feeed49

oxlint no-confusing-void-expression forbids returning the void expression from the arrow shorthand passed to expect().

This was referenced Jul 19, 2026

feat(mobile): pinned "Active now" tray on the Agents session list #4626

Open

feat(notifications): agent-callable push notification tool (cloud + mobile) #4627

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Notify and surface when a remote/cloud-agent session needs input#4605

Notify and surface when a remote/cloud-agent session needs input#4605
iscekic wants to merge 10 commits into
mainfrom
feature/mobile-agent-attention-notifications

iscekic commented Jul 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kilo-code-bot Bot commented Jul 18, 2026 •

edited

Loading

Previous review (commit `feeed49`)

Executive Summary

Overview

SUGGESTION

Previous review (commit `dc86ab9`)

Executive Summary

Overview

SUGGESTION

Previous review (commit `1602719`)

Executive Summary

Overview

WARNING

SUGGESTION

Uh oh!

iscekic commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

iscekic commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Backend push triggers

Session title in push notifications

In-app session-list indicator (mobile)

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kilo-code-bot Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Executive Summary

Previous review (commit feeed49)

Executive Summary

Overview

SUGGESTION

Previous review (commit dc86ab9)

Executive Summary

Overview

SUGGESTION

Previous review (commit 1602719)

Executive Summary

Overview

WARNING

SUGGESTION

Uh oh!

iscekic commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

iscekic commented Jul 16, 2026 •

edited

Loading

kilo-code-bot Bot commented Jul 18, 2026 •

edited

Loading

Previous review (commit `feeed49`)

Previous review (commit `dc86ab9`)

Previous review (commit `1602719`)